Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): add debug logs for join key with high amplification #16799

Merged
merged 3 commits into from
May 17, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented May 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Adapted from @yuhao-su's commit 4132bee, so we can have a general mechanism to debug this case.

It can be enabled with RUST_LOG="hash_join_amplification=debug"

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmatz
Copy link
Contributor

lmatz commented May 17, 2024

do you want to include it into v1.9.0, we still got some time before releasing it today

@kwannoel
Copy link
Contributor Author

do you want to include it into v1.9.0, we still got some time before releasing it today

Hmm okay we can merge it in first.

@kwannoel kwannoel enabled auto-merge May 17, 2024 05:54
@kwannoel kwannoel disabled auto-merge May 17, 2024 05:58
@kwannoel kwannoel enabled auto-merge May 17, 2024 06:18
@kwannoel kwannoel added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 31cc7c0 May 17, 2024
27 of 28 checks passed
@kwannoel kwannoel deleted the kwannoel/add-targetted-logs branch May 17, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants